Skip to content

Schema: Created Maximal Schemas for Gov & CMS code.json#38

Merged
natalialuzuriaga merged 5 commits intomainfrom
nat/schema-major-updates
Sep 4, 2025
Merged

Schema: Created Maximal Schemas for Gov & CMS code.json#38
natalialuzuriaga merged 5 commits intomainfrom
nat/schema-major-updates

Conversation

@natalialuzuriaga
Copy link
Copy Markdown
Contributor

Problem

We would like to include optional fields from the original code.json schema into our new schemas

Solution

  • Created CMS Maximal Schema v2
  • Created Gov Maximal Schema v2
  • Updated tests accordingly

Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Copy link
Copy Markdown
Contributor

@decause-gov decause-gov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1 🚢

Comment thread tests/cms-schema.json Outdated
@@ -1,5 +1,5 @@
{
"target": "../schemas/cms/schema-0.2.0.json",
"target": "../schemas/cms/schema-1.0.0.json",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this why fails?

Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
Signed-off-by: Natalia Luzuriaga <natalia.luzuriaga@cms.hhs.gov>
@natalialuzuriaga natalialuzuriaga merged commit 58927fe into main Sep 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants